Stop the reporter naming a path that no longer exists #2

claude · 2026-09-07T12:15:07Z

claude commented

2026-09-07 12:15:07 +00:00

The comment report_job_log.py posts said:

posted by tools/report_job_log.py

Since weblib-archive#44 there is no such file in any consuming repo — the
script lives here. So it pointed a reader at a path they cannot find, at the
one moment they are already hunting for the cause of a failure. Now links here.

How it was found, because the method matters more than the fix. I added the
reporter to weblib-fs (#31 there) and did not merge on green: a green run never
executes if: failure(), so merging would have shipped an untested failure
path — the same shape as a skip reading as a pass. So I deliberately broke that
build, watched the reporter post, and reverted. The stale path was visible only
in that posted comment.

Also notes in the module docstring that this script is consumed from other
repos, so its output must not name paths inside the repo it is reporting on.

The comment `report_job_log.py` posts said: > posted by `tools/report_job_log.py` Since weblib-archive#44 there is no such file in any consuming repo — the script lives here. So it pointed a reader at a path they cannot find, at the one moment they are already hunting for the cause of a failure. Now links here. **How it was found, because the method matters more than the fix.** I added the reporter to weblib-fs (#31 there) and did not merge on green: a green run never executes `if: failure()`, so merging would have shipped an untested failure path — the same shape as a skip reading as a pass. So I deliberately broke that build, watched the reporter post, and reverted. The stale path was visible only in that posted comment. Also notes in the module docstring that this script is consumed from other repos, so its output must not name paths inside the repo it is reporting on.

claude added 1 commit 2026-09-07 12:15:08 +00:00

Stop the reporter naming a path that no longer exists f9777ccbd2

The comment it posts said "posted by `tools/report_job_log.py`". Since
weblib-archive#44 there is no such file in any consuming repo -- the script
lives here. So it pointed a reader at a path they cannot find, on the one
occasion they are already looking for the cause of a failure.

Links here instead.

Found by deliberately breaking a build on weblib-fs#31 to prove the failure
path worked. A green run never renders this message, so nothing else would
have surfaced it.

Co-authored-by: bit <bit@das-labor.org>

claude requested review from bit 2026-09-07 12:15:08 +00:00

bit approved these changes 2026-09-07 12:43:52 +00:00

claude merged commit 3a0d8db656 into main

2026-09-07 12:44:27 +00:00

claude deleted branch fix/reporter-self-reference

2026-09-07 12:44:27 +00:00

claude referenced this issue from a commit

2026-09-07 12:44:28 +00:00

Merge pull request 'Stop the reporter naming a path that no longer exists' (#2) from fix/reporter-self-reference into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Reference: weblib/weblib-ci#2